Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace LPCTSTR with LPCWSTR #597

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Conversation

jmelas
Copy link
Contributor

@jmelas jmelas commented Jun 9, 2021

This PR removes the last occurance of TCHAR from the portaudio code by explicitly using wchar_t.

@RossBencina
Copy link
Collaborator

What is the logic of using Wide Char here instead of the ASCII version? The parameter is just for internal names of events.

At the moment this change has zero effect since the name parameter is allways passed NULL.

@jmelas
Copy link
Contributor Author

jmelas commented Jun 16, 2021

What is the logic of using Wide Char here instead of the ASCII version? The parameter is just for internal names of events.

At the moment this change has zero effect since the name parameter is allways passed NULL.

From MSDN: "Internally, the ANSI version translates the string to Unicode"
https://docs.microsoft.com/en-us/windows/win32/learnwin32/working-with-strings
So the W functions are always faster.

@RossBencina
Copy link
Collaborator

Thanks!

@RossBencina RossBencina merged commit 038a696 into PortAudio:master Jun 23, 2021
@jmelas jmelas deleted the no_tchar branch June 23, 2021 10:25
illuusio pushed a commit to illuusio/portaudio that referenced this pull request Oct 21, 2021
illuusio pushed a commit to illuusio/portaudio that referenced this pull request Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants