Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: export compile definitions for host APIs #635

Merged
merged 1 commit into from
Nov 13, 2021

Conversation

Be-ing
Copy link
Collaborator

@Be-ing Be-ing commented Aug 25, 2021

This allows applications to guard usage of host API specific
extensions with #ifdefs without the application's build system
needing to check for the existence of the host API specific header.

This allows applications to guard usage of host API specific
extensions with #ifdefs without the application's build system
needing to check for the existence of the host API specific header.
@Be-ing
Copy link
Collaborator Author

Be-ing commented Nov 13, 2021

Any comments on this?

Copy link
Collaborator

@dmitrykos dmitrykos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, sorry I overlooked this PR review request.

@dmitrykos dmitrykos merged commit 00a0143 into PortAudio:master Nov 13, 2021
@Be-ing Be-ing deleted the export_hostapi_defines branch November 13, 2021 22:23
This was referenced Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants