Add docker build workflow #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
frankh
commented
May 25, 2023
•
frankh
commented
- add github actions to build containers
- create a helm chart for deploying
- proxy api via frontend so we can have a single entrypoint (simplifies deployment a lot)
- use npm run start instead of serve (serve doesn't support proxying :()
- should fix this to use a proper server at some point
yakkomajuri
reviewed
May 25, 2023
housewatch/clickhouse/client.py
Outdated
| ch_ca = os.getenv("CLICKHOUSE_CA", None) | ||
| ch_secure = os.getenv("CLICKHOUSE_SECURE", True) | ||
| ch_secure = os.getenv("CLICKHOUSE_SECURE", "true") == "true" |
There was a problem hiding this comment.
this won't work because we want to default to true, yet docker will give us an empty string here
|
was def on my list to publish an image for this, thanks! |
|
can't do |
|
I spent a little bit of time today and yesterday getting arm64 containers built and resolving the issues raised. I want to confirm I'm on the right path towards getting this PR merged: |
frankh
force-pushed
the
frank/chart
branch
2 times, most recently
from
288ff1f
to
edc681b
Compare
BrandesEric
reviewed
Jul 17, 2023
| - "3000:3000" | ||
| ======= | ||
| network_mode: "service:web" | ||
| >>>>>>> 0921a8c (Add helm chart) |
There was a problem hiding this comment.
Just FYI, it looks like a set of merge conflict markers was checked in here....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.