fix: warn on unavailable lazy load not throw #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +168 B (+0.01%) Total Size: 1.18 MB
ℹ️ View Unchanged
|
jurajmajerik
approved these changes
Sep 6, 2024
pauldambra
commented
Sep 6, 2024
| logger.warn(LOGGER_PREFIX, 'canActivateRepeatedly is not defined, must init before calling') | ||
| return false // TODO does it make sense to have a default here? |
There was a problem hiding this comment.
@jurajmajerik @dmarticus i'm unfamiliar with this (and lazy 🤣 )
is it safe to return false here? will we accidentally disable surveys or something?
There was a problem hiding this comment.
I think this is fine.
This method is called here: https://github.com/PostHog/posthog-js/blob/fix/warn-not-throw/src/posthog-surveys.ts#L182
If you don't return false early than an error will be thrown on return.
@Phanatic can you double check please? I believe you've added this recently.
Phanatic
approved these changes
Sep 9, 2024
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #1344
we're checking the presence of a method on something that could be undefined
but we don't correctly type all the lazy load stuff, so TS doesn't complain
this at least safely checks the presence and will warn instead
we're likely calling the method too early (before it has had a chance to be added to the window) this might even be safe, so we definitely shouldn't throw