Add incremental building #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
reviewed
Jan 12, 2021
| @@ -22,6 +22,7 @@ | |||
| "@mdx-js/mdx": "^1.6.19", | |||
| "@mdx-js/react": "^1.6.19", | |||
| "antd": "^3.23.2", | |||
| "cross-env": "^7.0.3", | |||
There was a problem hiding this comment.
This looks like a devDependency actually. Though I also think we don't really support development on Windows, so not sure how much is this needed.
There was a problem hiding this comment.
This PR is based on this Netlify tutorial but yeah we don't necessarily need it. Also, Netlify calls gatsby build and I believe it doesn't install dev dependencies, hence this is here
There was a problem hiding this comment.
Thinking again maybe we should keep it in case a contributor uses Windows. Not sure if they'd currently run into other problems though.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.