Imgix plugin #849
Merged
Imgix plugin #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick look and images are not showing on the preview site - without much digging I wonder if that has to do with the context? If that's the case it'd actually be important to have the images in dev too |
mariusandra
force-pushed
the
imgix-plugin
branch
from
d76883b to
a0fafb2
Compare
|
whoops, forgot some quotes |
|
I think there might be a caching issue with the deploy preview now. :/ |
|
@mariusandra still no images :( |
|
Oh if it's a cache issue that's easy, I'll retrigger a deploy without cache |
|
Done - let's see |
|
Yup that's working now, and the great news is, for a cacheless build: |
yakkomajuri
approved these changes
Jan 14, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once #848 is merged, this can be added on top.
This adds a custom gatsby plugin that rewrites local images to use imgix in production builds (disabled for branch and deploy previews).
It finds every local image, gets its dimensions and then generates a srcSet attribute with matching imgix urls.
For an image like:
https://posthog.com/static/33fac05700a7fd86bd306b4c829493e7/d9ed5/toolbar-landing-page.png
We will generate urls like:
https://posthog.imgix.net/static/33fac05700a7fd86bd306b4c829493e7/d9ed5/toolbar-landing-page.png?w=500
... with different values for
w.PR #848 needs to be merged first, as without the
gatsby-remark-imagesplugin, the image URLs will be different, more like/static/feature-flags-1e8c20eefc3f0f8e8e72c0ce8101afcf.pnginstead of/static/hash1/hash2/feature-flags.png. If the new images are uploaded to production, we can test locally that this works withenabled: truebefore finally merging this.