Skip to content

Commit

Permalink
remove correlation analysis available feature check
Browse files Browse the repository at this point in the history
  • Loading branch information
thmsobrmlr committed Apr 3, 2023
1 parent d5ca31c commit aff29f2
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
5 changes: 1 addition & 4 deletions frontend/src/queries/nodes/InsightViz/InsightContainer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,6 @@ export function InsightContainer({

const { activeView } = useValues(insightNavLogic(insightProps))

// const {
// // correlationAnalysisAvailable
// } = useValues(funnelLogic(insightProps))
const { isFunnelWithEnoughSteps, hasFunnelResults, areExclusionFiltersValid } = useValues(
funnelDataLogic(insightProps)
)
Expand Down Expand Up @@ -243,7 +240,7 @@ export function InsightContainer({
</div>
</Card>
{renderTable()}
{/* {!disableCorrelationTable && correlationAnalysisAvailable && activeView === InsightType.FUNNELS && (
{/* {!disableCorrelationTable && activeView === InsightType.FUNNELS && (
<FunnelCorrelation />
)} */}
</>
Expand Down
8 changes: 0 additions & 8 deletions frontend/src/scenes/funnels/funnelLogic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { eventUsageLogic } from 'lib/utils/eventUsageLogic'
import type { funnelLogicType } from './funnelLogicType'
import {
AnyPropertyFilter,
AvailableFeature,
BinCountValue,
CorrelationConfigType,
ElementPropertyFilter,
Expand Down Expand Up @@ -59,7 +58,6 @@ import { isFunnelsFilter, keyForInsightLogicProps } from 'scenes/insights/shared
import { teamLogic } from '../teamLogic'
import { personPropertiesModel } from '~/models/personPropertiesModel'
import { groupPropertiesModel } from '~/models/groupPropertiesModel'
import { userLogic } from 'scenes/userLogic'
import { visibilitySensorLogic } from 'lib/components/VisibilitySensor/visibilitySensorLogic'
import { elementsToAction } from 'scenes/events/createActionFromEvent'
import { groupsModel, Noun } from '~/models/groupsModel'
Expand Down Expand Up @@ -112,8 +110,6 @@ export const funnelLogic = kea<funnelLogicType>({
['currentTeamId', 'currentTeam'],
personPropertiesModel,
['personProperties'],
userLogic,
['hasAvailableFeature'],
groupsModel,
['aggregationLabel'],
groupPropertiesModel,
Expand Down Expand Up @@ -918,10 +914,6 @@ export const funnelLogic = kea<funnelLogicType>({
.filter((property) => !excludedPersonProperties.includes(property))
},
],
correlationAnalysisAvailable: [
(s) => [s.hasAvailableFeature],
(hasAvailableFeature): boolean => hasAvailableFeature(AvailableFeature.CORRELATION_ANALYSIS),
],
allProperties: [
(s) => [s.inversePropertyNames, s.excludedPropertyNames],
(inversePropertyNames, excludedPropertyNames): string[] => {
Expand Down

0 comments on commit aff29f2

Please sign in to comment.