-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data-exploration): errors in data table #13703
Conversation
Django tests red❗ |
No more! |
Perhaps we could use |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Problem
The data exploration events table swallowed all errors. No longer!
Changes
Before:
After:
Questions
I don't think we're exposing anything secret by passing on the ClickHouse error. However I don't know. Could we leak credentials or anything else this way? 🤔
How did you test this code?
Added tests for the backend. Checked the frontend in the browser.