Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-exploration): HogQL refactor, events list filters #13800

Merged
merged 16 commits into from
Jan 19, 2023

Conversation

mariusandra
Copy link
Collaborator

Problem

Bringing over a few refactors from #13264

Changes

  • Rename ExprParserContext to HogQLContext, and expr_parser.py to hogql.py
  • Add type: 'hogql' property filters
  • Make these filters work in the events table (passed hogql context to parse_prop_grouped_clauses)
  • Rename BreakdownFilter to TaxonomicBreakdownFilter to align with the filename
  • Improve inline query editor placeholder with helpful hints

How did you test this code?

  • Wrote tests for the events endpoint
  • Added filters manually in the interface

Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariusandra
Copy link
Collaborator Author

Thanks! This seems safe enough to get in, so going to merge. Work is actively ongoing, and I'm happy to address any new feedback in #13806 or other followups.

@mariusandra mariusandra merged commit 0ba4b36 into master Jan 19, 2023
@mariusandra mariusandra deleted the hogql-small-refactor branch January 19, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants