Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hogql): better error if placeholder in HogQL expression #14153

Merged
merged 9 commits into from
Feb 13, 2023

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Feb 8, 2023

Problem

Changes

Throws a slightly nicer looking error when accidentally using {placeholder} syntax within HogQL expressions, for example in insights or in the events table.

The previous error looked like we had explicitly forgotten to add a placeholder, while it was actually bad data. This makes it clear that no placeholders are allowed in user entered strings.

It's all part of a work in progress though...

How did you test this code?

Added a test.

Base automatically changed from hogql-select-statements to master February 13, 2023 13:25
@mariusandra mariusandra changed the title feat(hogql): working branch feat(hogql): better error if placeholder in HogQL expression Feb 13, 2023
@mariusandra mariusandra marked this pull request as ready for review February 13, 2023 13:49
@mariusandra
Copy link
Collaborator Author

Now that #14131 is in (thanks @Twixes), there's this PR that's stacked on top. Might as well get it in, as all followup work is now taking place in #14185

Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mariusandra mariusandra merged commit 2e39d7b into master Feb 13, 2023
@mariusandra mariusandra deleted the hogql-further-improvements branch February 13, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants