feat(hogql): properties between shards #14549
Conversation
| @@ -237,9 +237,38 @@ | |||
| /* user_id:0 request:_snapshot_ */ | |||
| SELECT event, | |||
| events.distinct_id, | |||
| replaceRegexpAll(JSONExtractRaw(events.properties, 'key'), '^"|"$', ''), | |||
| replaceRegexpAll(JSONExtractRaw(properties, 'key'), '^"|"$', ''), | |||
There was a problem hiding this comment.
Previously events. was added before properties to disambiguate it from the events__pdi__person.properties column that we selected in the join. That's no longer the case and thus it seems like it was automatically removed.
|
|
||
| context = HogQLContext(within_non_hogql_query=False, using_person_on_events=True) | ||
| self.assertEqual( | ||
| # TODO: for now, explicitly writing "poe." to opt in. Automatic switching will come soon. |
There was a problem hiding this comment.
HogQL is not yet able to turn PoE (in its current form) on or off depending on the team's settings. It is doing this inside existing insights (non-hogql queries), but not in full hogql queries. This is planned for another PR.
| "person.properties.name", | ||
| "person.properties.email", |
There was a problem hiding this comment.
Why the change from person.properties?
There was a problem hiding this comment.
Mainly for speed. I don't think we need to return the entire properties object with every event. There are rumours of possible customers incoming with 10k+ properties per person, etc. This makes it more in line with what selecting "person" returns in this table.
Problem
Accessing an event's person's properties in HogQL would fetch the entire properties object and send it back to us the main select query.
Changes
Extracts properties within the person subquery and only returns those. Cutting down a lot on traffic between shards.
I do not have benchmarks, but looking at the queries, the effects should be similar to this: #13935
How did you test this code?
Wrote tests. Checked that all worked in the browser.