fix(events-explorer): events explorer improvements #14648
Conversation
…to events-table-interval
| for column_index, column in enumerate(select_input_raw): | ||
| if column != "person": | ||
| continue | ||
| for index, result in enumerate(query_result.results): |
There was a problem hiding this comment.
I'm not super clear on what all is going on in these things yet 🙈
This is an in-memory loop not an N+1 query?
There was a problem hiding this comment.
These are all in memory loops.
To get it to work, just select more than "last 24h"
There was a problem hiding this comment.
To get it to work, just select more than "last 24h"
🙈 🤣
Then I get
There was a problem hiding this comment.
return !!personRecord.distinct_ids.length ? (
when
{
"uuid": "01869ed9-85a3-0000-f0dc-c6dbf095aef6",
"created_at": "2023-03-01T20:24:59.852Z",
"properties": {
"name": null,
"email": "paul@posthog.com"
},
"distinct_id": "a0JNkovhz54zqTBN2pBKf8jqA488qudRnugUzVshN2E"
}
There was a problem hiding this comment.
Dumping in
else if (key === 'person' && isEventsQuery(query.source)) {
const personRecord = value as PersonType
let distinctId = undefined
if (personRecord.distinct_ids && personRecord.distinct_ids.length > 0) {
distinctId = personRecord.distinct_ids[0]
} else if (personRecord.distinct_id) {
distinctId = personRecord.id
}
return distinctId ? (
<Link to={urls.person(distinctId)}>
<PersonHeader noLink withIcon person={personRecord} />
</Link>
) : (
<PersonHeader noLink withIcon person={value} />
)
}
and the table displays (although the type system is unhappy)
There was a problem hiding this comment.
whoops. Should be fixed now 🙈
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Problem
Changes
How did you test this code?
Added a test and clicked around locally.