feat(hogql): automatic event and person property types #14795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
approved these changes
Mar 17, 2023
Comment on lines
+17
to
+37
| event_property_values = ( | ||
| PropertyDefinition.objects.filter( | ||
| name__in=property_finder.event_properties, | ||
| team_id=context.team_id, | ||
| type__in=[None, PropertyDefinition.Type.EVENT], | ||
| ).values_list("name", "property_type") | ||
| if property_finder.event_properties | ||
| else [] | ||
| ) | ||
| event_properties = {name: property_type for name, property_type in event_property_values if property_type} | ||
|
|
||
| person_property_values = ( | ||
| PropertyDefinition.objects.filter( | ||
| name__in=property_finder.person_properties, | ||
| team_id=context.team_id, | ||
| type=PropertyDefinition.Type.PERSON, | ||
| ).values_list("name", "property_type") | ||
| if property_finder.person_properties | ||
| else [] | ||
| ) | ||
| person_properties = {name: property_type for name, property_type in person_property_values if property_type} |
There was a problem hiding this comment.
Might be quicker for me to ask than figure it out #Lazy
How often do we call this?
Might be early-optimizing but the property types change infrequently so we can cache seen properties relatively aggressively. Makes me wonder how well our tracing covers this code 🤔
There was a problem hiding this comment.
This will just be called once per query in most cases. In case of non-hogql insights, it'll be called once per filter. This is where caching could make the biggest difference, but I didn't feel like overoptimising yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
All properties were always returned as strings
Changes
Not any more! We now wrap all columns specified as
NumericwithtoFloat64OrNull, allDateTimecolums withparseDateTimeBestEffortand allBooleancolumns withcol = 'true'I think we should split
Numericup intoIntegerandFloatfor accuracy, as treating everything as a float is weird... and ClickHouse'sDecimalrequires a fixed precision which seems like too big of a decision to make.How did you test this code?
Wrote tests. Checked in the UI. Checking CI now for all the extra queries this makes.