feat(query): rate limit to 120 requests/min #14873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Q: Do you want this to apply in the UI? Because right now these rate limits are only for the API accessed via a personal API key |
|
Yep, that's exactly what I want. People should be able to experiment in the UI as much as they want, including clicking "reload" and then "cancel" over 120 times in a minute (though why and how would you). This however is to just prevent abuse via the API. |
neilkakkar
approved these changes
Mar 23, 2023
|
Sorry thought I had approved with the first comment 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want a separate set of rate limits to HogQL queries.
Changes
Implements almost this. The
/api/projects/:id/queryendpoint now gets a120 queries per hourlimit. This should be enough to block users who accidentally abuse the system, and also allow legit users to do things.The previous rate limits were "4800/hour" (ClickHouseSustainedRateThrottle) and "240/minute" (ClickHouseBurstRateThrottle)
How did you test this code?
I didn't really. Copied what I found under api/feature_flag.py and hoping for the best.