feat: handle pricing & features better for addons in ingestion flow #15219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that we don't have to deal with pricing for that right now Few people self-serve for enterprise anyway
charlottemcginn
approved these changes
Apr 25, 2023
|
There is a bit more work to do here as @charlottemcginn and I discussed this morning but since this is behind a FF (mostly) I'm going to merge it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The ingestion flow didn't include addon pricing, but would still subscribe someone to the Group Analytics addon if they sub'd to Product Analytics.
Changes
Plan comparison modal on ingestion now shows pricing for the main product and its addons:
The pricing is wrong in the above screenshot - I'll look into that and fix in a PR in the billing service, this is just for the UI.
And the ingestion screen lists features out better:
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
👀