Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: write recording summary events #15245
feat: write recording summary events #15245
Changes from 4 commits
a65131b
0302f4e
81095e9
e212b50
c1a7064
5ee61aa
d468b04
906b0c4
bb0fb16
45a7fa9
84f12ea
beff2fb
f3e0b94
bfaf0a2
60ced21
ceac97c
d067d51
a8ef254
32d19ca
a49b91f
020fca2
9d77f79
476d33a
5dfdf15
5cab032
94f64e0
54b36ce
18f9ab6
f05ccec
7d78183
e7e08d7
bef878e
dde2c76
bda15ae
b657765
2e7786e
922734e
495e4f7
eaf5852
7869a6f
db76ca5
81ba357
ac6578d
3473dac
1bff3e2
80e45eb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never know if this is the case but isn't the missing ? after trim meaning that it could throw if there is no href?
Also why not use truthiness and keep it simple :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The elvis operator says if the thing is there carry on if not return undefined
I prefer the explicit
!!
to remind myself I'm using truthiness but no strong opinion. I'll see what the tests think of the suggestion and go from there :)