feat(hogql): use readonly user for hogql queries if available #15889
Conversation
| has_joins="JOIN" in clickhouse_sql, | ||
| has_json_operations="JSONExtract" in clickhouse_sql or "JSONHas" in clickhouse_sql, |
There was a problem hiding this comment.
How accurate do we want to be with these two tags? Since we have the full modified pre-printer AST available to us (lazy tables expanded, etc), we can just use a quick visitor that checks if there's a select query with any joins for a 100% accurate answer. See e.g. AggregationFinder in property.py. The current simple check will also catch ARRAY JOIN-s, which I'm not sure if it's the intention or not.
As for JSONExtract, that's trickier to autodetect based on HogQL, as property access is expanded in the printer. So yeah, this here is the safest way though there might be some extremely rare duplicates.
All in all, do with the context above what you think is best :).
There was a problem hiding this comment.
As of right now I just moved this since the default for all queries is to do lookups like this.
It was happening inside insight_sync_execute.
Will just keep as is for now
safety and all.
tested locally and it works