feat(hogql): null-tolerant concat #15975
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
concat
-ing anynull
value makes everything nullconcat
-ing any numbers or booleans makes everything crashWe likely want to store
null
properties asnull
s, but concat messes this up.Changes
Makes
concat
null-tolerant (sounds the opposite of what it is). Now the following:gets automatically converted to
Also adds the piped concat operator:
Actual property access inside a ClickHouse SQL string while inside a concat looks kind of dorky, but should be accurate. We can definitely simplify this further if we need to.
Questions
Do we want this? I'd consider it a big UX improvement. Otherwise I need to put the
ifNull
-s everywhere myself, as I can never be too sure every property is always set.We can alternatively make properties always take default values, but that has its own issues and is not concluded yet. This fix seems like a happy middle ground bandage.
Alternatives
Alternatively we can implement a new type of non-ANSI compliant string operator, e.g.
f'{NULL}-haha-{properties.bla}'
, but I'd keep the operators standard and be flexible with the types instead.How did you test this code?
Added tests