-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hogql): null handling with == and != comparisons, attempt 2 #16259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusandra
changed the title
fix(hogql): null handling with == and != comparisons
fix(hogql): null handling with == and != comparisons, attempt 2
Jun 27, 2023
mariusandra
changed the title
fix(hogql): null handling with == and != comparisons, attempt 2
fix(hogql): null handling with == and != comparisons, attempt 2
Jun 27, 2023
Twixes
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a lot better 👌
This was referenced Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Attempt nr 2 for #16216
Changes
Compared to the previous PR, this implements a
nullable
property on all fields (default False), which opts fields into special null handling. I found only two fields in the database that were nullable, both on the session_recordings table. All properties are still treated as nullable.I kept the join constraint node and check, as without true type checking and propagation, we can't say if a join constraint from a subquery is nullable or not.
How did you test this code?
bin/tests posthog/hogql
isNull(argMax())
around argMax code inside those lazy tables adds no slowdown.