feat(hogql): local evaluation (HogVM part 2) #16275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsobrmlr
approved these changes
Jun 28, 2023
| describe('HogQL Bytecode', () => { | ||
| test('execution results', () => { | ||
| const fields = { properties: { foo: 'bar' } } | ||
| expect(executeHogQLBytecode(['_h', op.INTEGER, 2, op.INTEGER, 1, op.PLUS], fields)).toBe(3) |
There was a problem hiding this comment.
It might be nice to re-use the generated bytecode from the python tests e.g. by storying them in a JSON file keyed by HogQL expression.
There was a problem hiding this comment.
Definitely agree. I'd like to get to a state where we can confidently say the same code executes the same way on all platforms. Let's leave this for a future refactor. Thanks for the review! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The HogQL local evaluation PR (aka HogVM) is getting out of control. I'll split it into at least
threefour. This is part two, and it contains the HogVM local evaluation engine. Part 3 will add cohort support. Part 4 will connect this to actions.Changes
---> View the README for HogVM for more details. <---
Next steps
in cohortworking. The VM shouldn't know about our data model, but just ask the lightweight wrapper around it for an async answer tois 'Timmy' in cohort 2.How did you test this code?
Added tests.