Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are a number of small bugs with notebooks, specifically around the recording timestamps
Changes
queueMicrotask
to make sure they don't get called during a re-render. This does not fix all of the flushSync issuesNotebook
component and only when the editor is set on the logic does it issue a command to set the focus.right
to fix them showing to the left of the cursor when the notebook is being viewed in compact modeHow did you test this code?
By 👁️