Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hogvm): bytecode in state #22740

Merged
merged 11 commits into from
Jun 6, 2024
Merged

feat(hogvm): bytecode in state #22740

merged 11 commits into from
Jun 6, 2024

Conversation

mariusandra
Copy link
Collaborator

Changes

Return the bytecode in the VM state, so it could directly be passed back for re-execution.

Would this make anything easier?

How did you test this code?

Ran the tests

@mariusandra mariusandra changed the title feat(hogvm): json parsing feat(hogvm): bytecode in state Jun 6, 2024
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Size Change: 0 B

Total Size: 1.06 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.06 MB

compressed-size-action

Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't feel strongly either way about this. It neither helps nor hinders based on the work I did around it 🤷

@mariusandra
Copy link
Collaborator Author

mariusandra commented Jun 6, 2024

Fair... now we can do this though 😅

while(!response?.finished) { response = exec(response ?? code)) };

@mariusandra mariusandra merged commit c440893 into master Jun 6, 2024
79 checks passed
@mariusandra mariusandra deleted the bytecode-serial branch June 6, 2024 09:30
thmsobrmlr pushed a commit that referenced this pull request Jun 6, 2024
@mariusandra mariusandra mentioned this pull request Jun 6, 2024
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants