Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hog): dict globals in autocomplete #23288

Merged
merged 17 commits into from
Jun 28, 2024
Merged

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Jun 27, 2024

Problem

We want to control the autocomplete inputs for Hog templates

Changes

Autocomplete the actual object:

2024-06-27 16 33 49

How did you test this code?

Added relevant tests

Copy link
Contributor

github-actions bot commented Jun 27, 2024

Size Change: 0 B

Total Size: 1.06 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.06 MB

compressed-size-action

@mariusandra mariusandra marked this pull request as ready for review June 28, 2024 09:42
Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code wise everything looked fine. Didn't look too closely though...

@mariusandra mariusandra merged commit c73fde6 into master Jun 28, 2024
91 checks passed
@mariusandra mariusandra deleted the hog-autocomplete-inputs branch June 28, 2024 13:56
@mariusandra mariusandra mentioned this pull request Jun 28, 2024
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants