feat(hogvm): add RE2 for TypeScript VM #23558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update the TypeScript HogVM to use
re2for regexp matching.This avoids ReDoS errors.
How did you test this code?
All tests continue to pass.
What about Python?
I looked into it and opted to keep the Python HogVM using regular Python
refor now. I could install a python package (the officialre2package is out of date, pyre2 is better), but that requires everyone to runbrew install re2or equivalent to get some.hfiles.Since we're not using the Python HogVM in production anywhere, I'll skip the hassle for now and keep it as a TODO to revisit if we ever want to use that for anything.