fix(flags): better redistribute experience #25611
Conversation
|
Size Change: +1.09 kB (+0.1%) Total Size: 1.14 MB
|
…osthog into fix/better-redistribute-button
| onClick={distributeVariantsEqually} | ||
| tooltip="Redistribute variant rollout percentages equally" | ||
| > | ||
| <IconBalance /> |
| <LemonButton | ||
| onClick={distributeVariantsEqually} | ||
| tooltip="Redistribute variant rollout percentages equally" | ||
| > | ||
| <IconBalance /> | ||
| </LemonButton> |
There was a problem hiding this comment.
If I'm gonna nitpick I'd still bump it over to line up with the right side of the column, but if not then I think this is fine 👍
There was a problem hiding this comment.
nitpick addressed!
| <LemonButton | ||
| onClick={distributeVariantsEqually} | ||
| tooltip="Redistribute variant rollout percentages equally" | ||
| > | ||
| <IconBalance /> | ||
| </LemonButton> |
There was a problem hiding this comment.
If I'm gonna nitpick I'd still bump it over to line up with the right side of the column, but if not then I think this is fine 👍
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Head branch was modified
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Problem
Per @raquelmsmith's feedback here, I redid the
redistributeexperience for the flags UI to now use a button with a tooltip instead of the word "redistribute" on a button. I also changed the percentage rollout input boxes to have the%suffix; it looks better IMO.Worked with Cory to use a scale balance icon for this thing, since I figured that was a good visual indicator for rebalancing variant distributions.
Changes
Demo: https://www.loom.com/share/9ccb4e1e8303434cbdc1daca86a11855