feat(experiments HogQL): calculate statistics for Funnels #25626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurajmajerik
changed the title
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
neilkakkar
reviewed
Oct 17, 2024
| self.assertAlmostEqual(result.credible_intervals["control"][0], 0.1941, places=3) | ||
| self.assertAlmostEqual(result.credible_intervals["control"][1], 0.9324, places=3) | ||
| self.assertAlmostEqual(result.credible_intervals["test"][0], 0.2836, places=3) | ||
| self.assertAlmostEqual(result.credible_intervals["test"][1], 0.9473, places=3) |
There was a problem hiding this comment.
i'm surprised this is not flaky, old runner needed the flaky decorator on these tests because sometimes the values will be a bit off.
neilkakkar
approved these changes
Oct 17, 2024
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated5 snapshot changes in total. 0 added, 5 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
timgl
pushed a commit
that referenced
this pull request
Oct 17, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Same as #25562 but for Funnels.
How did you test this code?