Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bi): Added support for number and bool vars #25633

Merged
merged 5 commits into from
Oct 18, 2024
Merged

Conversation

Gilbert09
Copy link
Member

Changes

  • Added support for boolean and number insight vars

that is all

@Gilbert09 Gilbert09 requested a review from a team October 16, 2024 17:24
Copy link
Contributor

github-actions bot commented Oct 16, 2024

Size Change: 0 B

Total Size: 1.14 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.14 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Base automatically changed from tom/duplicate-vars to master October 17, 2024 15:27
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

5 snapshot changes in total. 0 added, 5 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@Gilbert09 Gilbert09 enabled auto-merge (squash) October 17, 2024 19:45
@Gilbert09 Gilbert09 merged commit 6ca6a43 into master Oct 18, 2024
94 checks passed
@Gilbert09 Gilbert09 deleted the tom/variable-types branch October 18, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants