Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to easily get the first not empty string in Hog/QL:
In JavaScript:
In Hog:
In HogQL
The only real way to get
banana
is:... but we could do better.
Changes
Introducing
stringOr(null, '', 'banana', 'dingo')
and its shorthand^^
Why
^^
?Looking at my keyboard, I found these underutilised symbols in our language:
! $ % ^ & _ ~
. I excluded symbols that are common bitwise operators or used elsewhere in Hog, and added a bunch of doubles.The question became: which of these is the most natural/obvious?
... and that's how I settled on
^^
How did you test this code?
I didn't yet. This is a WIP in the spirit of "the fastest way to get the right answer is to post the wrong answer on the internet".
To test locally, run
pip install ./hogql_parser
. If you change the^^
inHogQLLexer.g4
and want to play around, runpnpm run grammar:build
followed bypip install ./hogql_parser
.Alternatives
We claim back
||
, however it is a standard SQL concatenation operator. We have advertised it and people are using it in queries, so it'll be a hard fight.