feat(cdp): better logging of fetch failures #25665
Open
+64
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusandra
approved these changes
Oct 18, 2024
Comment on lines
122
to
+126
| resParams.response = { | ||
| status: fetchResponse.status, | ||
| body: responseBody, | ||
| headers: Object.fromEntries(fetchResponse.headers.entries()), | ||
| } | ||
| resParams.body = responseBody |
There was a problem hiding this comment.
I don't fully get why body moved one level higher. It's still part of the response, no? I do see this is used for internal housekeeping and not directly exposed to the users, so it's probably fine, but this misdirection still confuses me. Why not just keep the erroring response/body also in the same object?
In any case, I'm not too opinionated on this small remark, just though it's worth bringing up.
There was a problem hiding this comment.
The body is a level higher because even in failure cases it's possible to get a body back (some 500s or 400s get a body, those are "failed" fetches, but they might still have useful info for the user)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cyclotron worker provides a bunch of information we don't bubble up to users, this makes debugging harder and doesn't spark joy. This PR is an attempt to fix that