-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dnsdist 1.5 support + updated test framework #27
Conversation
…fy if dnsdist started properly and succesfully parsed its config file
…(due to changes in dnsdist user defaults)
@@ -1,6 +1,4 @@ | |||
[Service] | |||
{% for k, v in dnsdist_service_overrides.items() %} | |||
{% if k == 'ExecStart' %}ExecStart= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaik, systemd requires and empty ExecStart
to clear the full value. Otherwise it appends. See man systemd.unit
Note that for drop-in files, if one wants to remove entries from a setting that is parsed as a list (and is not a dependency), such as AssertPathExists= (or e.g. ExecStart= in service units), one needs to first clear the list before re-adding all entries except the one that is to be removed. Dependencies (After=, etc.) cannot be reset to an empty list, so dependencies can only be added in drop-ins. If you want to remove dependencies, you have to override the entire unit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's correct and needs to be added back.
It also seems like we need the same thing to be done for the ExecStartPre to avoid that from being triggered multiple times with potentially incorrect parameters.
…ion to reset them
Both ExecStart & ExecStartPre are now reset if they have an override:
|
Includes: