-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major refactoring of the install procedure #3
Conversation
|
||
dnsdist_install_repo: False | ||
|
||
By default the PowerDNS Recursor is installed from the os default repositories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/PowerDNS Recursor/dnsdist/
dnsdist_install_repo: False | ||
|
||
By default the PowerDNS Recursor is installed from the os default repositories. | ||
You can install the PowerDNS Recursor package from official PowerDNS repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/PowerDNS Recursor/dnsdist/
- hosts: pdns-dnsdists | ||
roles: | ||
- { role: PowerDNS.dnsdist, | ||
dnsdist_install_repo: "{{ dnsdist_official_dnsdist_master }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'official' sounds very...... uhm.. official.. I don't have a better suggestion though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switched to dnsdist_powerdns_repo_master
.
template: | ||
src: dnsdist.conf.j2 | ||
dest: /etc/dnsdist/dnsdist.conf | ||
validate: 'dnsdist -C %s --check-config 2>&1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with this line here, the validation in the handler can go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in 806f75a
- repository | ||
|
||
- include: install-epel.yml | ||
when: ansible_os_family == 'RedHat' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should have a dnsdist_install_epel
variable to support people that have private EPEL-like repos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good hint! ;-)
Please squash your changes before merging 👍 |
Major refactoring of the tasks adding the PowerDNS official repositories.