Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdnsutil check-zone: accept LUA A/AAAA as SVCB address targets #14011

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Apr 2, 2024

Short description

Avoids [Error] SVCB record svcb.example.com has a target sub.svcb.example.com that has neither address nor SVCB records. when there is a valid LUA A or LUA AAAA at the target name.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@coveralls
Copy link

coveralls commented Apr 2, 2024

Pull Request Test Coverage Report for Build 8557145261

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 26 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-2.0%) to 59.489%

Files with Coverage Reduction New Missed Lines %
pdns/pollmplexer.cc 1 82.39%
pdns/dnsdistdist/dnsdist-crypto.cc 2 75.72%
pdns/backends/gsql/gsqlbackend.hh 2 97.14%
pdns/opensslsigners.cc 2 60.93%
pdns/tsigverifier.cc 3 77.22%
pdns/misc.cc 3 61.48%
pdns/signingpipe.cc 5 83.6%
ext/luawrapper/include/LuaContext.hpp 8 14.11%
Totals Coverage Status
Change from base Build 8556256233: -2.0%
Covered Lines: 114074
Relevant Lines: 159279

💛 - Coveralls

@Habbie Habbie merged commit 617d2f0 into PowerDNS:master Apr 8, 2024
75 of 76 checks passed
@Habbie Habbie deleted the check-zone-svcb-lua-addr branch April 8, 2024 14:46
swegener added a commit to swegener/pdns that referenced this pull request May 30, 2024
Merge PowerDNS#14011 added checking for LUA records to checkZone(), but LUA
records depend on --enable-lua-records and the change causes a build
error without.

Signed-off-by: Sven Wegener <sven.wegener@stealer.net>
Habbie pushed a commit to Habbie/pdns that referenced this pull request Sep 25, 2024
Merge PowerDNS#14011 added checking for LUA records to checkZone(), but LUA
records depend on --enable-lua-records and the change causes a build
error without.

Signed-off-by: Sven Wegener <sven.wegener@stealer.net>
(cherry picked from commit 175b5e6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants