Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ixfrSuck: init soatimes without separate memset #14684

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

zeha
Copy link
Collaborator

@zeha zeha commented Sep 19, 2024

Short description

Trivially replace initialisation of soatimes in ixfrSuck.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

coveralls commented Sep 19, 2024

Pull Request Test Coverage Report for Build 10980886032

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 43 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+3.4%) to 64.728%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/auth-secondarycommunicator.cc 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
modules/gpgsqlbackend/gpgsqlbackend.cc 1 89.43%
pdns/pollmplexer.cc 1 84.31%
pdns/recursordist/aggressive_nsec.cc 2 66.47%
pdns/sstuff.hh 2 56.83%
pdns/backends/gsql/gsqlbackend.hh 2 97.71%
modules/lmdbbackend/lmdbbackend.cc 2 72.62%
pdns/misc.cc 2 63.37%
pdns/dnsdistdist/dnsdist.cc 2 68.36%
pdns/recursordist/test-syncres_cc2.cc 3 89.03%
pdns/stubresolver.cc 3 77.58%
Totals Coverage Status
Change from base Build 10961070589: 3.4%
Covered Lines: 124826
Relevant Lines: 162213

💛 - Coveralls

Copy link
Member

@Habbie Habbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, however, you have angered the clang-tidy god

@zeha
Copy link
Collaborator Author

zeha commented Sep 19, 2024

I fear I will anger it further by trying to appease it. Will see :)

@zeha
Copy link
Collaborator Author

zeha commented Sep 22, 2024

I think clang-tidy for auth passed with this.

@Habbie Habbie merged commit 780fa96 into PowerDNS:master Oct 8, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants