rec: rpz tweaks

[omoerbeek]

Short description

• Log policyname on policyHit when updating root
• Do not register invalid file-based RPZs
• Do not return null SOA (this should no longer happen with the 2nd bullet, but better safe than sorry)

2nd commit: do not apply NS based policies to (recursive) forwarders. This commit is debatable, hence draft status.

Checklist

I have:

• read the CONTRIBUTING.md document
• compiled this code
• tested this code
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)

[coveralls]

Pull Request Test Coverage Report for Build 10996038105

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 6 of 10 (60.0%) changed or added relevant lines in 3 files are covered.
• 36 unchanged lines in 10 files lost coverage.
• Overall coverage increased (+0.03%) to 64.712%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pdns/recursordist/rec-main.cc	4	6	66.67%
pdns/recursordist/syncres.cc	1	3	33.33%

Files with Coverage Reduction	New Missed Lines	%
pdns/recursordist/rec-main.cc	1	62.16%
pdns/validate.cc	1	68.42%
modules/lmdbbackend/lmdbbackend.cc	2	73.46%
pdns/recursordist/syncres.cc	3	79.83%
pdns/opensslsigners.cc	3	61.41%
modules/gpgsqlbackend/spgsql.cc	3	67.7%
pdns/misc.cc	4	63.43%
pdns/recursordist/test-syncres_cc1.cc	5	89.63%
pdns/recursordist/rec-tcpout.cc	5	50.79%
pdns/dnsdistdist/dnsdist-carbon.cc	9	62.16%

Totals
Change from base Build 10994193892:	0.03%
Covered Lines:	124847
Relevant Lines:	162221

---

💛 - Coveralls

[omoerbeek]

BTW, the RPZ regression test failures are happening because they use forwarding, which with this PR are no longer subjected to RPZ policies. If we decide the 2nd commit is there to stay, we need to adapt the tests.

[omoerbeek]

I decided to drop the 2nd commit for this PR, and just keep logging- and bugfix.