-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rec: Give a more clear error message if the build fails because python was not found #14697
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 10960690682Details
💛 - Coveralls |
In our case python2 was installed, but python3 was needed if I remember correctly. |
Ah, I'll extend the test to include that case then |
…n was not found When building from a src tarball you don't need python (the tarball includes the generated files), but that changes if settings/table.py was modified or when building from a github checkout.
3de813f
to
030f54a
Compare
Ah, TIL "Python 4.0 will probably never come" :) |
I plan to be retired by then. |
@@ -23,6 +23,8 @@ BUILT_SOURCES=cxxsettings-generated.cc rust/src/lib.rs | |||
# | |||
# Use patterns to avoid having two instances of generate run simultaneously, a well-known hack for GNU make | |||
cxxsettings-generated%cc rust/src/lib%rs: table.py generate.py rust-preamble-in.rs rust-bridge-in.rs docs-old-preamble-in.rst docs-new-preamble-in.rst | |||
@if test "$(PYTHON)" = ":"; then echo "Settings table table.py has changed, need python to regenerate generated settings files but python was not found"; exit 1; fi | |||
@if ! $(PYTHON) --version | grep -q "Python 3"; then echo $(PYTHON) should be at least version 3; exit 1; fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should both cases say something about needing to reconfigure/remeson?
But don't report an error during configure:
When building from a src tarball you don't need python (the tarball includes the generated files), but that changes if settings/table.py was modified or when building from a github checkout.
Short description
Checklist
I have: