Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: move checkForCorrectTSIG into packethandler #14701

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

zeha
Copy link
Collaborator

@zeha zeha commented Sep 23, 2024

Short description

Avoid DNSPacket pulling UeberBackend.

This is a refactoring commit from #14594 which I think stands on its own.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

coveralls commented Sep 23, 2024

Pull Request Test Coverage Report for Build 10992787570

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 38 of 50 (76.0%) changed or added relevant lines in 3 files are covered.
  • 1760 unchanged lines in 50 files lost coverage.
  • Overall coverage increased (+3.4%) to 64.719%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/dnspacket.cc 6 8 75.0%
pdns/tcpreceiver.cc 6 9 66.67%
pdns/packethandler.cc 26 33 78.79%
Files with Coverage Reduction New Missed Lines %
pdns/packethandler.cc 1 72.77%
modules/gpgsqlbackend/gpgsqlbackend.cc 1 88.62%
pdns/recursordist/aggressive_nsec.cc 2 66.17%
pdns/epollmplexer.cc 2 83.75%
pdns/libssl.hh 2 0.0%
ext/yahttp/yahttp/utility.hpp 2 36.69%
pdns/burtle.hh 2 98.16%
modules/lmdbbackend/lmdbbackend.cc 2 73.46%
pdns/channel.hh 2 53.03%
pdns/pollmplexer.cc 2 83.66%
Totals Coverage Status
Change from base Build 10961070589: 3.4%
Covered Lines: 124860
Relevant Lines: 162222

💛 - Coveralls

@zeha
Copy link
Collaborator Author

zeha commented Sep 23, 2024

green!

@Habbie Habbie merged commit 42c3a1e into PowerDNS:master Sep 26, 2024
80 checks passed
@zeha zeha deleted the zeha-13039-refac branch September 26, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants