Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth-4.9: Fix build with boost 1.86.0 #14709

Open
wants to merge 1 commit into
base: rel/auth-4.9.x
Choose a base branch
from

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Sep 25, 2024

Short description

backport of #14562

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

Boost 1.86.0 changes seem to no longer indirectly include header which
causes build to fail with:
```
uuid-utils.cc:38:58:
error: 'random' is not a class, namespace, or enumeration
```

boost/random/mersenne_twister.hpp has been available since Boost 1.21.2

(cherry picked from commit eed5600)
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11032415194

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.03%) to 63.166%

Files with Coverage Reduction New Missed Lines %
pdns/backends/gsql/gsqlbackend.hh 2 97.71%
modules/lmdbbackend/lmdbbackend.cc 2 73.42%
pdns/ws-auth.cc 2 80.81%
pdns/auth-secondarycommunicator.cc 2 64.59%
pdns/tsigverifier.cc 3 77.22%
pdns/rcpgenerator.cc 3 90.23%
Totals Coverage Status
Change from base Build 11032388645: 0.03%
Covered Lines: 41768
Relevant Lines: 59383

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants