Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth-4.9: provide dns packet when doing lookup for presigned signatures #14712

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Sep 25, 2024

Short description

backport of #14394

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11032581712

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.04%) to 63.174%

Files with Coverage Reduction New Missed Lines %
pdns/packethandler.cc 1 72.51%
pdns/auth-secondarycommunicator.cc 2 64.65%
Totals Coverage Status
Change from base Build 11032388645: 0.04%
Covered Lines: 41786
Relevant Lines: 59383

💛 - Coveralls

@zeha
Copy link
Collaborator

zeha commented Sep 25, 2024

clang-tidy was angered with too short var names :)

@Habbie
Copy link
Member Author

Habbie commented Sep 26, 2024

clang-tidy was angered with too short var names :)

then clang-tidy is going to take one for the team ;)

@Habbie Habbie merged commit d54be0e into PowerDNS:rel/auth-4.9.x Sep 26, 2024
29 of 30 checks passed
@Habbie Habbie deleted the backport-14394-to-auth-4.9.x branch September 26, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants