Remove mocha-junit-reporter package by relying on Mocha's xUnit module
#3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's out of date and is missing a security fix.
|
Unfortunately we also still need to do something about |
andyleejordan
force-pushed
the
andschwa/xunit
branch
from
dea0094
to
57233ec
Compare
|
Ugh the ADO test reporter can't read this xUnit output. |
So we can remove a vulnerable package.
andyleejordan
force-pushed
the
andschwa/xunit
branch
from
57233ec
to
d64e185
Compare
andyleejordan
changed the title
mocha-junit-reporter package by relying on Mocha's xUnit module
|
Filed mochajs/mocha#4758 upstream, because I'm confused. |
rjmholt
approved these changes
Sep 29, 2021
|
Looks like rewire's dependency was soft enough that this PR mitigated the issue. 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This important because the removed package (
mocha-junit-reporter) is quite out-of-date and pulls in a vulnerable dependency. Funnily, we're still producing JUnit-style XML test results, which is a very curious bug in Mocha itself.