Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the Terminal Shell Integration setting is changed #4971

Merged
merged 1 commit into from
May 21, 2024

Conversation

andyleejordan
Copy link
Member

Because if it is, we'll need to restart the Extension Terminal (unless it was hidden at startup).
Also add a test to ensure we can find VS Code's script (in case its location changes upstream).

@andyleejordan andyleejordan added the Issue-Enhancement A feature request (enhancement). label Apr 9, 2024
@andyleejordan andyleejordan requested a review from a team April 9, 2024 20:43
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan added this pull request to the merge queue Apr 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 15, 2024
@andyleejordan andyleejordan added this pull request to the merge queue Apr 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 15, 2024
Because if it is, we'll need to restart the Extension Terminal
(unless it was hidden at startup).
Also add a test to ensure we can find VS Code's script
(in case its location changes upstream).
@andyleejordan andyleejordan added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 509c9a3 May 21, 2024
7 checks passed
@andyleejordan andyleejordan deleted the shell-integration-test branch May 21, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement A feature request (enhancement).
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants