Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is being done ahead of Bootstrap 5. In v5, they changed how
data-toggle="collapse"
is handled. Now, they handle click events for that in the capturing phase instead of the bubbling phase (see twbs/bootstrap#36063). This means that we no longer have the option of usingstopPropagation()
to ensure that clicks on nested buttons don't toggle the open/closed state. I opened twbs/bootstrap#40574 to change Bootstrap to handle these events in the bubbling phase, but that's unlikely to be reviewed or released soon.Now, collapse toggling is controlled only by an explicit button. The main user-facing change is that clicking on question submission/feedback panel headers will no longer toggle the open/closed state of the panel. IMO this is strictly (if indeed slightly) worse, but 🤷
I made some accessibility improvements as I went:
aria-expanded
/aria-controls
attributespl-external-grader-results
to use abutton
as a toggle instead of adiv
. This ensures that it can be navigated and operated with a keyboard.