Default manifest #855
Merged
Default manifest #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarlevin
force-pushed
the
default-manifest
branch
2 times, most recently
from
a4d4104 to
2a4fc48
Compare
…s not allowed in contexts
oscarlevin
force-pushed
the
default-manifest
branch
from
f9bb25b to
7430463
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of work to make it possible for a user to build a standalone pretext document. So far it just creates a default project when no manifest is found in the tree above the cwd. So if someone has their directory set up as default but doesn't have project.ptx, things will still work.
The next step (before this gets merged) will be to have the CLI build and view commands accept an optional additional argument for a filename that will be used as the source.
Note: I ran into some issues with Python 3.13 and mypy, complaining about Path objects not being allowed in "contexts" There were a couple spots where we were doing this, so I converted those. In one case that meant using a file_like object instead (
with open(Path, "r") as file) and in the other just declaring the needed variable instead of using a context.@StevenClontz, feel free to weigh in at any time if you like, but no pressure.