Use an indeterminate checkbox pattern for p-table select all. #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
<p-table />component to use an indeterminate checkbox for the multiselect permutation's (de)select-all box.Of note, aside from just the visual change of utilizing the indeterminate state, this pattern slightly changes the behavior as well. The checkbox is now considered "checked" if any row is selected so that clicking the checkbox now deselects all selected rows when any is selected. Compare this to previous behavior where checking when not all rows are selected will select all.
This change was done to be more inline with the visual appearance of the indeterminate state (which has a minus sign so when some, but not all rows are selected, the behavior will remove selections)