Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[p-wizard] Skip navigations #1209

Merged
merged 8 commits into from
Apr 16, 2024
Merged

[p-wizard] Skip navigations #1209

merged 8 commits into from
Apr 16, 2024

Conversation

collincchoy
Copy link
Collaborator

This PR adds navigation "shortcuts" to the wizard namely:

  • step headers are now clickable
    • if you've completed the step already, then you can go straight to that step via headers rather than stepping 1-by-1
    • you can pass the nonlinear prop to the wizard to allow skipping steps without the completion check - i.e. when revisiting a previously completed wizard form
  • when the wizard is passed a show-save-and-exit prop, a new button is available on all but the last step to execute the current step's validator and then emit a 'submit' event without having to step through the entire wizard. This gives you a short circuit out of the wizard - i.e. when revisiting a previously completed wizard form and attempting to make a change in 1 step without having to cycle through the rest of the wizard to submit.

@collincchoy collincchoy requested a review from a team as a code owner April 16, 2024 14:23
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for prefect-design ready!

Name Link
🔨 Latest commit 3ae1a70
🔍 Latest deploy log https://app.netlify.com/sites/prefect-design/deploys/661e89c8862a6e00088954e5
😎 Deploy Preview https://deploy-preview-1209--prefect-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for prefect-design ready!

Name Link
🔨 Latest commit 20cda2e
🔍 Latest deploy log https://app.netlify.com/sites/prefect-design/deploys/661e89d044c9a90008350271
😎 Deploy Preview https://deploy-preview-1209--prefect-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@pleek91 pleek91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@collincchoy collincchoy merged commit a1376ee into main Apr 16, 2024
6 checks passed
@collincchoy collincchoy deleted the p-wizard/skip-nav branch April 16, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants