Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Sentiment Tokens #1217

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Refactor Sentiment Tokens #1217

merged 2 commits into from
Apr 18, 2024

Conversation

aaazzam
Copy link
Collaborator

@aaazzam aaazzam commented Apr 18, 2024

Today we have four sentiment tokens: positive, negative, neutral, and warning.

  • These tokens take the same value on light and dark mode, so they've been moved to the true :root.
  • These colors were each assigned individual CSS Vars for their hue, sturation, and lightness indivudually, remixed into a hsl-token, and finally remixed into a color creating 4 * 5 * 2 = 40 CSS variables.
    • This PR reduces the number of variables to 8 CSS variables.

First of a handful of PRs to reduce the surface area of our design tokens to make them easier to maintain.

@aaazzam aaazzam requested a review from a team as a code owner April 18, 2024 15:46
Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for prefect-design ready!

Name Link
🔨 Latest commit b33060f
🔍 Latest deploy log https://app.netlify.com/sites/prefect-design/deploys/662142f5e629b500083ad827
😎 Deploy Preview https://deploy-preview-1217--prefect-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@pleek91 pleek91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One though but probably unlikely to become an issue.

src/styles/index.css Outdated Show resolved Hide resolved
Copy link
Collaborator

@pleek91 pleek91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@aaazzam aaazzam merged commit 08e119c into main Apr 18, 2024
6 checks passed
@aaazzam aaazzam deleted the refactor-sentiment-tokens branch April 18, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants