Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Design + Compat-layer #1240

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Button Design + Compat-layer #1240

merged 4 commits into from
Apr 24, 2024

Conversation

aaazzam
Copy link
Collaborator

@aaazzam aaazzam commented Apr 24, 2024

This PR is a backwards-compatible compat-layer between our old taxonomy of button variants and sizes and new:

  • default, primary, flat, and dangerous
  • outline, default, ghost, destructive, and link (new, unimplemented).

This is backwards compatible in the sense that all old props still work, all existing buttons do the same thing.

@aaazzam aaazzam requested a review from a team as a code owner April 24, 2024 17:42
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for prefect-design ready!

Name Link
🔨 Latest commit 3df2208
🔍 Latest deploy log https://app.netlify.com/sites/prefect-design/deploys/662944706fb28e0008663259
😎 Deploy Preview https://deploy-preview-1240--prefect-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@pleek91 pleek91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So ghost is the new name for flat?

@aaazzam aaazzam merged commit 85c5db6 into main Apr 24, 2024
6 checks passed
@aaazzam aaazzam deleted the button-migration branch April 24, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants