Downgrade typescript from 5.5 -> 5.4 to fix improper p-table generic typing #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t correctly propogating.
✅ Deploy Preview for prefect-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
znicholasbrown
approved these changes
Jul 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency bump seems to have caused downstream issues with
<p-table />. Specifically, the generic types around TableData don't seem to be working correctly. Downstream consumption breaks on scoped slot type inference where therowshould be inferred from the passed in data type, but is instead being picked up as justTableData.Found some potentially related issues in vue-tsc around TS 5.5 and changes related to
@vue/runtime-core, but neither changing the global TS declaration (for global components) nor updating the tsconfig.json to include(as mentioned in those issues) seemed to fix the issue. Going to revert this upgrade for now.