Use correct paths in GcsBucket.put/get_directory

[rooperuu]

closes #12487

Fixes target path resolution in GcsBucket methods. Currently, in put_directory, the bucket_folder prefix is added twice, and in get_directory, the prefix is not removed.

Example

GCS target file for put_directory given local source file from_path/file.txt:

• Before: bucket_folder/bucket_folder/to_path/file.txt
• After: bucket_folder/to_path/file.txt

Local target file for get_directory given GCS source file bucket_folder/from_path/file.txt:

• Before: to_path/from_path/file.txt
• After: to_path/file.txt

Checklist

• This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.
• This pull request references any related issue by including "closes <link to issue>"
  • If no issue exists and your change is not a small fix, please create an issue first.
• If this pull request adds new functionality, it includes unit tests that cover the changes
• If this pull request removes docs files, it includes redirect settings in mint.json.
• If this pull request adds functions or classes, it includes helpful docstrings.

[zzstoatzz]

hi @rooperuu ! thank you for the PR

this generally looks good to me, but 2 questions:

• why switch away from self.write_path here?
• can you add a test for the new path creation logic?

[rooperuu]

Thanks for taking a look! I have updated the tests for get_directory to ensure that correct paths are used. Testing put_directory is a bit more tricky unless the return value can be changed, as it currently only returns the number of files.

Regarding the other point, the problem was that path resolution was done both in put_directory and in write_path, so one or the other should be eliminated. This approach is more similar to the one in get_directory.

[aaazzam]

Thanks @rooperuu for adding those tests. @zzstoatzz does this LGTU? Would love to get this merged / released since this is blocking for this team. 🙇

[zzstoatzz]

thank you @rooperuu !