-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
agent start
CLI command now allows for kwargs
#1737
Conversation
Interesting, looks like a few tests are failing on 3.5 for unrelated reasons:
|
Looks like google made some python releases very recently: https://github.com/googleapis/google-cloud-python/releases/tag/storage-1.23.0 You can either:
|
Going to change the bounds now. Doesn't appear they dropped support for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, i think this is a significant improvement
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md
(if appropriate)docs/outline.toml
for API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
Closes #1734
prefect agent start
now accepts kwargs. This is useful for users when providing the configuration options for the Fargate Agent.e.g.
Why is this PR important?
Having to provide kwargs in the boto3 camel casing convention could potentially lead to conflicts in environment variable names when using external tooling (e.g. Terraform) to deploy the Agent.
Instead of having to do:
$ export memory=512 $ prefect agent start fargate
There is now the option to use custom names: