Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement out-of-process flow run pauses #7863

Merged
merged 79 commits into from
Dec 13, 2022
Merged

Implement out-of-process flow run pauses #7863

merged 79 commits into from
Dec 13, 2022

Conversation

anticorrelator
Copy link
Contributor

Finishes core work on #7410

This extends the pause_flow_run utility to accept a flow_run_id, and will attempt to pause a flow from outside of the flow process. Once paused, the NEXT task run to be orchestrated will be marked as NotReady and the flow run will at that point terminate gracefully. Any task runs already running will be allowed to finish. This flow run can be resumed either via the UI or via the resume_flow_run utility.

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement

@anticorrelator
Gracefully exit from in-process nonblocking pauses
a431451
@anticorrelator
Add route that implements the resume action
c56c52e
@anticorrelator
Use resume API
9e39b55
@anticorrelator
Implement pause counter
fa1d5f1
@anticorrelator
Only run in-process pauses once
2debec7
@anticorrelator
Do not increment run count for resuming flows
c490916
@anticorrelator
Prevent invalid transitions out of Paused states
7855d62
@anticorrelator
Use better names
d52d4f3
@anticorrelator
Merge branch 'main' of github.com:PrefectHQ/prefect into nonblocking-…
ccdc8cd 
…pauses
@anticorrelator
Reset flow pause metadata on retry
fd12d66
@anticorrelator
Prevent late flow pause resumptions
4ad1deb
@anticorrelator
Handle failure to resume flows in resume_flow_run utility
84e8fa9
@anticorrelator
Add pause expiration migration
894c737
@anticorrelator
Track pause expiration metadata
e530cf9
@anticorrelator
Add service to fail expired paused flow runs
c79c545
@anticorrelator
Merge branch 'main' of github.com:PrefectHQ/prefect into nonblocking-…
1dd1d7c 
…pauses
@anticorrelator
Finish wiring up pause expiration service
c9d8ea5
@anticorrelator
Always set original flow policy for rule cleanup
6a337da
@anticorrelator
Abort resuming a flow that isn't pause
30a1d69
@anticorrelator
Include pause expiration index in migrations
9265ab4
@anticorrelator
Use new run count incrementer transforms in tests
4048b41
@anticorrelator
Catch FailedRun exception
67ec9f6
@anticorrelator
Add tests for nonblocking pauses
c84393f
@anticorrelator
Add tests for resuming API
28c24b9
@anticorrelator
Add pausing rule tests
00530ec
@anticorrelator
Add resuming rule tests
f13c673
@anticorrelator
⚫
45af65a
@anticorrelator
Remove resuming indicator in a separate rule
2b471b1
@anticorrelator
Update engine tests to monkeypatch deployments
5190733
@anticorrelator
Merge branch 'main' of github.com:PrefectHQ/prefect into nonblocking-…
c6b254e 
…pauses
zanieb
zanieb approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anticorrelator anticorrelator merged commit c7e6913 into main Dec 13, 2022
@anticorrelator anticorrelator deleted the out-of-process-pauses branch December 13, 2022 00:10
bunchesofdonald pushed a commit that referenced this pull request Dec 13, 2022
@anticorrelator @zangell44 @bunchesofdonald
Implement out-of-process flow run pauses (#7863)
f70ac98 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
@zanieb zanieb mentioned this pull request Dec 14, 2022
Merged
3 tasks
github-actions bot pushed a commit to ddelange/prefect that referenced this pull request Dec 15, 2022
@anticorrelator @zangell44 @github-actions
Implement out-of-process flow run pauses (PrefectHQ#7863)
5745323 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
zanieb pushed a commit that referenced this pull request Dec 15, 2022
@anticorrelator @zangell44 @zanieb
Implement out-of-process flow run pauses (#7863)
88ccfa7 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
zanieb pushed a commit that referenced this pull request Dec 15, 2022
@anticorrelator @zangell44 @zanieb
Implement out-of-process flow run pauses (#7863)
bd5b0cf 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
zanieb pushed a commit that referenced this pull request Dec 22, 2022
@anticorrelator @zangell44 @zanieb
Implement out-of-process flow run pauses (#7863)
4eca421 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
zanieb pushed a commit that referenced this pull request Dec 22, 2022
@anticorrelator @zangell44 @zanieb
Implement out-of-process flow run pauses (#7863)
badc7a9 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Dec 29, 2022
@anticorrelator @zangell44 @peytonrunyan
Implement out-of-process flow run pauses (#7863)
0e5f971 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Dec 29, 2022
@anticorrelator @zangell44 @github-actions
Implement out-of-process flow run pauses (#7863)
c427083 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jan 4, 2023
@anticorrelator @zangell44 @madkinsz
Implement out-of-process flow run pauses (#7863)
e7c176b 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jan 4, 2023
@anticorrelator @zangell44 @github-actions
Implement out-of-process flow run pauses (#7863)
eb33842 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jan 6, 2023
@anticorrelator @zangell44 @madkinsz
Implement out-of-process flow run pauses (#7863)
915d2ae 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jan 6, 2023
@anticorrelator @zangell44 @github-actions
Implement out-of-process flow run pauses (#7863)
502aa35 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jan 12, 2023
@anticorrelator @zangell44 @madkinsz
Implement out-of-process flow run pauses (#7863)
38feb68 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jan 12, 2023
@anticorrelator @zangell44 @github-actions
Implement out-of-process flow run pauses (#7863)
36b73ab 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jan 19, 2023
@anticorrelator @zangell44 @peytonrunyan
Implement out-of-process flow run pauses (#7863)
4ed6a1f 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jan 19, 2023
@anticorrelator @zangell44 @github-actions
Implement out-of-process flow run pauses (#7863)
b6d5a33 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jan 26, 2023
@anticorrelator @zangell44 @madkinsz
Implement out-of-process flow run pauses (#7863)
03f489b 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Jan 26, 2023
@anticorrelator @zangell44 @github-actions
Implement out-of-process flow run pauses (#7863)
8780fa9 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
@zanieb zanieb mentioned this pull request Feb 3, 2023
Merged
3 tasks
zanieb pushed a commit that referenced this pull request Feb 3, 2023
@anticorrelator @zangell44 @zanieb
Implement out-of-process flow run pauses (#7863)
8d3c824 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
zanieb pushed a commit that referenced this pull request Feb 3, 2023
@anticorrelator @zangell44 @zanieb
Implement out-of-process flow run pauses (#7863)
19c5696 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
@zanieb zanieb mentioned this pull request Feb 6, 2023
Merged
zanieb pushed a commit that referenced this pull request Feb 6, 2023
@anticorrelator @zangell44 @zanieb
Implement out-of-process flow run pauses (#7863)
87b8522 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
zanieb pushed a commit that referenced this pull request Feb 6, 2023
@anticorrelator @zangell44 @zanieb
Implement out-of-process flow run pauses (#7863)
cc004e9 
Co-authored-by: Zach Angell <42625717+zangell44@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

@zangell44 zangell44 Awaiting requested review from zangell44

Assignees
No one assigned
Labels
feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anticorrelator @zanieb